Allocating SLH for http server with configuring httpHeapMaxBlocks in yaml #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
h/httpserver.h
Outdated
| @@ -220,6 +224,7 @@ typedef struct HTTPServerConfig_tag { | |||
| hashtable *userTimeouts; | |||
| hashtable *groupTimeouts; | |||
| int defaultTimeout; | |||
| unsigned int httpHeapMaxBlocks; | |||
There was a problem hiding this comment.
Use a more specific name; for example, httpRequestHeapMaxBlocks.
| @@ -5821,7 +5821,9 @@ static int httpHandleTCP(STCBase *base, | |||
| } | |||
| } | |||
| #endif // USE_ZOWE_TLS | |||
| ShortLivedHeap *slh = makeShortLivedHeap(READ_BUFFER_SIZE,100); | |||
| HttpServer *server = (HttpServer*) module->data; | |||
| unsigned int maxBlocks = server->config->httpRequestHeapMaxBlocks; | |||
There was a problem hiding this comment.
This field should probably be initialized by this point in the httpserver.c code. The reason is, the httpserver.c might be used by non-zss applications which don't know about this filed and might not initialize it.
Gautham-coder
force-pushed
the
config-slh-maxblocks
branch
from
b68d383
to
041d803
Compare
Gautham-coder
force-pushed
the
config-slh-maxblocks
branch
from
df35a61
to
041d803
Compare
… value. Signed-off-by: Gautham Kuppuswamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The heap available to the http server is currently capped to around 6MB, because of this there is a limit in the size of the dataset that can be uploaded using ZSS API's.
To solve this, we are providing an option in configuration under 'components ->zss ->httpHeapMaxBlocks'. By default it would be 1024 meaning, 64KB * 1024, and as of now we have capped the max value of this option to be 4096 meaning, 64kb * 4096.
This PR addresses Issue: zowe/zss#698
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
You can try with uploading a dataset with size greater than 6mb using a python script